deprecate the unused localTaintStep and stringStep predicates

erik-krogh · erik-krogh · commit 8f86b067e7d8 · 2022-03-13T23:54:53.000+01:00
diff --git a/javascript/ql/lib/semmle/javascript/dataflow/DataFlow.qll b/javascript/ql/lib/semmle/javascript/dataflow/DataFlow.qll
@@ -1718,5 +1718,5 @@ module DataFlow {
   import TypeTracking
   import internal.FunctionWrapperSteps
 
-  predicate localTaintStep = TaintTracking::localTaintStep/2;
+  deprecated predicate localTaintStep = TaintTracking::localTaintStep/2;
 }
diff --git a/javascript/ql/lib/semmle/javascript/dataflow/TaintTracking.qll b/javascript/ql/lib/semmle/javascript/dataflow/TaintTracking.qll
@@ -431,7 +431,7 @@ module TaintTracking {
    * Holds if `pred -> succ` is a taint propagating data flow edge through a string operation.
    */
   pragma[inline]
-  predicate stringStep(DataFlow::Node pred, DataFlow::Node succ) {
+  deprecated predicate stringStep(DataFlow::Node pred, DataFlow::Node succ) {
     stringConcatenationStep(pred, succ) or
     stringManipulationStep(pred, succ)
   }
@@ -1243,7 +1243,7 @@ module TaintTracking {
   /**
    * Holds if taint propagates from `pred` to `succ` in one local (intra-procedural) step.
    */
-  predicate localTaintStep(DataFlow::Node pred, DataFlow::Node succ) {
+  deprecated predicate localTaintStep(DataFlow::Node pred, DataFlow::Node succ) {
     DataFlow::localFlowStep(pred, succ) or
     sharedTaintStep(pred, succ)
   }

Original file line number	Diff line number	Diff line change
`@@ -1718,5 +1718,5 @@ module DataFlow {`
`1718`	`1718`	`import TypeTracking`
`1719`	`1719`	`import internal.FunctionWrapperSteps`
`1720`	`1720`
`1721`		`- predicate localTaintStep = TaintTracking::localTaintStep/2;`
	`1721`	`+ deprecated predicate localTaintStep = TaintTracking::localTaintStep/2;`
`1722`	`1722`	`}`