Update python/ql/src/experimental/Security/CWE-022bis/TarSlipImprov.ql

Sim4n6 · yoff · web-flow · commit 925f9d09e517 · 2022-10-21T21:06:51.000+01:00
Co-authored-by: yoff &lt;lerchedahl@gmail.com&gt;
diff --git a/python/ql/src/experimental/Security/CWE-022bis/TarSlipImprov.ql b/python/ql/src/experimental/Security/CWE-022bis/TarSlipImprov.ql
@@ -101,10 +101,10 @@ class Configuration extends TaintTracking::Configuration {
       nodeTo = call
     )
     or
-    exists(DataFlow::CallCfgNode closing |
+    exists(API::CallNode closing |
       closing = API::moduleImport("contextlib").getMember("closing").getACall() and
       nodeFrom = closing.getArg(0) and
-      nodeFrom = tarfileOpen().getACall() and
+      nodeFrom = tarfileOpen().getReturn().getAValueReachingSink() and
       nodeTo = closing
     )
   }

Original file line number	Diff line number	Diff line change
`@@ -101,10 +101,10 @@ class Configuration extends TaintTracking::Configuration {`
`101`	`101`	`nodeTo = call`
`102`	`102`	`)`
`103`	`103`	`or`
`104`		`- exists(DataFlow::CallCfgNode closing \|`
	`104`	`+ exists(API::CallNode closing \|`
`105`	`105`	`closing = API::moduleImport("contextlib").getMember("closing").getACall() and`
`106`	`106`	`nodeFrom = closing.getArg(0) and`
`107`		`- nodeFrom = tarfileOpen().getACall() and`
	`107`	`+ nodeFrom = tarfileOpen().getReturn().getAValueReachingSink() and`
`108`	`108`	`nodeTo = closing`
`109`	`109`	`)`
`110`	`110`	`}`