C++: add class and test for a GNU vector fill operation

nickrolfe · nickrolfe · commit 93103e10423b · 2018-09-07T12:07:28.000+01:00
diff --git a/cpp/ql/src/semmle/code/cpp/exprs/BuiltInOperations.qll b/cpp/ql/src/semmle/code/cpp/exprs/BuiltInOperations.qll
@@ -369,3 +369,10 @@ class BuiltInOperationIsFinal extends BuiltInOperation, @isfinalexpr {
 class BuiltInChooseExpr extends BuiltInOperation, @builtinchooseexpr {
   override string toString() { result = "__builtin_choose_expr" }
 }
+
+/**
+ * Fill operation on a GNU vector.
+ */
+class VectorFillOperation extends UnaryOperation, @vec_fill {
+  override string getOperator() { result = "(vector fill)" }
+}
diff --git a/cpp/ql/test/library-tests/vector_types/fill.expected b/cpp/ql/test/library-tests/vector_types/fill.expected
@@ -0,0 +1 @@
+| vector_types.cpp:51:18:51:18 | (vector fill) ... | file://:0:0:0:0 | __attribute((vector_size(16))) int | vector_types.cpp:51:18:51:18 | n | file://:0:0:0:0 | int |
diff --git a/cpp/ql/test/library-tests/vector_types/fill.ql b/cpp/ql/test/library-tests/vector_types/fill.ql
@@ -0,0 +1,5 @@
+import cpp
+
+from VectorFillOperation vf, Expr operand
+where operand = vf.getOperand()
+select vf, vf.getType(), operand, operand.getType()
diff --git a/cpp/ql/test/library-tests/vector_types/variables.expected b/cpp/ql/test/library-tests/vector_types/variables.expected
@@ -14,3 +14,6 @@
 | vector_types.cpp:33:8:33:9 | v5 | v5 | file://:0:0:0:0 | __attribute((vector_size(16))) double | 16 |
 | vector_types.cpp:34:10:34:16 | doubles | doubles | file://:0:0:0:0 | double[2] | 16 |
 | vector_types.cpp:41:14:41:16 | arg | arg | vector_types.cpp:7:14:7:17 | v16c | 16 |
+| vector_types.cpp:47:23:47:25 | dst | dst | file://:0:0:0:0 | v16i * | 8 |
+| vector_types.cpp:47:34:47:36 | src | src | file://:0:0:0:0 | v16i * | 8 |
+| vector_types.cpp:47:43:47:43 | n | n | file://:0:0:0:0 | int | 4 |
diff --git a/cpp/ql/test/library-tests/vector_types/vector_ops.expected b/cpp/ql/test/library-tests/vector_types/vector_ops.expected
@@ -1,2 +1,4 @@
 | vector_types.cpp:16:16:16:41 | ... == ... | == | file://:0:0:0:0 | __attribute((vector_size(16))) char |
 | vector_types.cpp:21:10:21:18 | ... < ... | < | file://:0:0:0:0 | __attribute((vector_size(16))) int |
+| vector_types.cpp:51:10:51:18 | ... << ... | << | file://:0:0:0:0 | __attribute((vector_size(16))) int |
+| vector_types.cpp:51:18:51:18 | (vector fill) ... | (vector fill) | file://:0:0:0:0 | __attribute((vector_size(16))) int |
diff --git a/cpp/ql/test/library-tests/vector_types/vector_types.cpp b/cpp/ql/test/library-tests/vector_types/vector_types.cpp
@@ -41,3 +41,12 @@ int main() {
 v4f lax(v16c arg) {
   return arg;
 }
+
+typedef int v16i __attribute__((vector_size(16)));
+
+void shift_left(v16i *dst, v16i *src, int n) {
+  // We represent this shift as an operation on vector types, and the
+  // right-hand side is a vector fill expression (i.e. a vector filled with n in
+  // each element).
+  *dst = *src << n;
+}

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+\| vector_types.cpp:51:18:51:18 \| (vector fill) ... \| file://:0:0:0:0 \| __attribute((vector_size(16))) int \| vector_types.cpp:51:18:51:18 \| n \| file://:0:0:0:0 \| int \|`