Python: Add missing global flow test

tausbn · tausbn · commit 9458861b1822 · 2020-09-17T12:04:30.000+02:00
diff --git a/python/ql/test/experimental/dataflow/tainttracking/taintlib.py b/python/ql/test/experimental/dataflow/tainttracking/taintlib.py
@@ -3,6 +3,8 @@
 TAINTED_LIST = ["tainted-{}".format(i) for i in range(5)]
 TAINTED_DICT = {"name": TAINTED_STRING, "some key": "foo"}
 
+NOT_TAINTED = "NOT_TAINTED"
+
 def ensure_tainted(*args):
     print("- ensure_tainted")
     for i, arg in enumerate(args):
diff --git a/python/ql/test/experimental/dataflow/tainttracking/unwanted-global-flow/test.py b/python/ql/test/experimental/dataflow/tainttracking/unwanted-global-flow/test.py
@@ -0,0 +1,32 @@
+import sys; import os; sys.path.append(os.path.dirname(os.path.dirname((__file__))))
+from taintlib import *
+
+# Various instances where flow is undesirable
+
+tainted = NOT_TAINTED
+ensure_not_tainted(tainted)
+
+def write_global():
+    global tainted
+    tainted = TAINTED_STRING
+
+tainted2 = TAINTED_STRING
+len(tainted2)
+tainted2 = NOT_TAINTED
+ensure_not_tainted(tainted2)
+
+def use_of_tainted2():
+    global tainted2
+    tainted2 = NOT_TAINTED
+
+# Flow via global assigment
+
+def write_tainted():
+    global g
+    g = TAINTED_STRING
+
+def sink_global():
+    ensure_tainted(g)
+
+write_tainted()
+sink_global()
diff --git a/python/ql/test/experimental/dataflow/tainttracking/unwanted-global-flow/testTaint.expected b/python/ql/test/experimental/dataflow/tainttracking/unwanted-global-flow/testTaint.expected
@@ -0,0 +1,3 @@
+| test.py:7 | ok   | test | tainted |
+| test.py:16 | ok   | test | tainted2 |
+| test.py:29 | ok   | sink_global | g |
diff --git a/python/ql/test/experimental/dataflow/tainttracking/unwanted-global-flow/testTaint.ql b/python/ql/test/experimental/dataflow/tainttracking/unwanted-global-flow/testTaint.ql
@@ -0,0 +1 @@
+import experimental.dataflow.tainttracking.TestTaintLib

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+\| test.py:7 \| ok \| test \| tainted \|`
	`2`	`+\| test.py:16 \| ok \| test \| tainted2 \|`
	`3`	`+\| test.py:29 \| ok \| sink_global \| g \|`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+import experimental.dataflow.tainttracking.TestTaintLib`