C++: Update comment.

geoffw0 · geoffw0 · commit 95c77ca3c690 · 2020-02-06T10:17:37.000Z
diff --git a/cpp/ql/test/query-tests/Security/CWE/CWE-807/semmle/TaintedCondition/test.cpp b/cpp/ql/test/query-tests/Security/CWE/CWE-807/semmle/TaintedCondition/test.cpp
@@ -35,7 +35,7 @@ void processRequest()
         adminPrivileges = 0; // OK, since it's a 0 and not a 1
      }
 
-     // BAD, but it requires pointer analysis to catch
+     // BAD (requires pointer analysis to catch)
      const char** userp = &currentUser;
      *userp = userName;
      if (!strcmp(currentUser, "admin")) {

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ void processRequest()`
`35`	`35`	`adminPrivileges = 0; // OK, since it's a 0 and not a 1`
`36`	`36`	`}`
`37`	`37`
`38`		`- // BAD, but it requires pointer analysis to catch`
	`38`	`+ // BAD (requires pointer analysis to catch)`
`39`	`39`	`const char** userp = &currentUser;`
`40`	`40`	`*userp = userName;`
`41`	`41`	`if (!strcmp(currentUser, "admin")) {`