Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 96e1732

Browse files
hvitvedhvitved
committed
C#: Address review comments
1 parent 6749bbd commit 96e1732

13 files changed

Lines changed: 488 additions & 445 deletions

‎csharp/ql/src/semmle/code/csharp/Caching.qll‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,13 +51,14 @@ module Stages {
5151
module DataFlowStage {
5252
private import semmle.code.csharp.dataflow.internal.DataFlowPrivate
5353
private import semmle.code.csharp.dataflow.internal.DataFlowImplCommon
54+
private import semmle.code.csharp.dataflow.internal.TaintTrackingPrivate
5455

5556
cached
5657
predicate forceCachingInSameStage() { any() }
5758

5859
cached
5960
private predicate forceCachingInSameStageRev() {
60-
TaintTracking::localTaintStep(_, _)
61+
localAdditionalTaintStep(_, _)
6162
or
6263
any(ArgumentNode n).argumentOf(_, _)
6364
or

‎csharp/ql/src/semmle/code/csharp/dataflow/DataFlow.qll‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ module DataFlow {
1313
* member predicates of `Configuration` and the rest of the data-flow library.
1414
* Good performance cannot be guaranteed in the presence of such recursion, so
1515
* it should be replaced by using more than one copy of the data flow library.
16-
* Four copies are available: `DataFlow` through `DataFlow4`.
16+
* Five copies are available: `DataFlow` through `DataFlow5`.
1717
*/
1818
abstract private class ConfigurationRecursionPrevention extends Configuration {
1919
bindingset[this]

‎csharp/ql/src/semmle/code/csharp/dataflow/DataFlow2.qll‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ module DataFlow2 {
1313
* member predicates of `Configuration` and the rest of the data-flow library.
1414
* Good performance cannot be guaranteed in the presence of such recursion, so
1515
* it should be replaced by using more than one copy of the data flow library.
16-
* Four copies are available: `DataFlow` through `DataFlow4`.
16+
* Five copies are available: `DataFlow` through `DataFlow5`.
1717
*/
1818
abstract private class ConfigurationRecursionPrevention extends Configuration {
1919
bindingset[this]

‎csharp/ql/src/semmle/code/csharp/dataflow/DataFlow3.qll‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ module DataFlow3 {
1313
* member predicates of `Configuration` and the rest of the data-flow library.
1414
* Good performance cannot be guaranteed in the presence of such recursion, so
1515
* it should be replaced by using more than one copy of the data flow library.
16-
* Four copies are available: `DataFlow` through `DataFlow4`.
16+
* Five copies are available: `DataFlow` through `DataFlow5`.
1717
*/
1818
abstract private class ConfigurationRecursionPrevention extends Configuration {
1919
bindingset[this]

‎csharp/ql/src/semmle/code/csharp/dataflow/DataFlow4.qll‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ module DataFlow4 {
1313
* member predicates of `Configuration` and the rest of the data-flow library.
1414
* Good performance cannot be guaranteed in the presence of such recursion, so
1515
* it should be replaced by using more than one copy of the data flow library.
16-
* Four copies are available: `DataFlow` through `DataFlow4`.
16+
* Five copies are available: `DataFlow` through `DataFlow5`.
1717
*/
1818
abstract private class ConfigurationRecursionPrevention extends Configuration {
1919
bindingset[this]

‎csharp/ql/src/semmle/code/csharp/dataflow/DataFlow5.qll‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ module DataFlow5 {
1313
* member predicates of `Configuration` and the rest of the data-flow library.
1414
* Good performance cannot be guaranteed in the presence of such recursion, so
1515
* it should be replaced by using more than one copy of the data flow library.
16-
* Four copies are available: `DataFlow` through `DataFlow4`.
16+
* Five copies are available: `DataFlow` through `DataFlow5`.
1717
*/
1818
abstract private class ConfigurationRecursionPrevention extends Configuration {
1919
bindingset[this]

0 commit comments

Comments
 (0)