Fix PR feedback

Dave Bartolomeo · Dave Bartolomeo · commit 99072483b81d · 2020-10-22T12:55:40.000-04:00
diff --git a/cpp/ql/src/semmle/code/cpp/models/implementations/StdPair.qll b/cpp/ql/src/semmle/code/cpp/models/implementations/StdPair.qll
@@ -20,7 +20,7 @@ class StdPairCopyishConstructor extends Constructor, TaintFunction {
   StdPairCopyishConstructor() {
     this.getDeclaringType() instanceof StdPairClass and
     this.getNumberOfParameters() = 1 and
-    this.getParameter(0).getUnspecifiedType().(ReferenceType).getBaseType().getUnspecifiedType()
+    this.getParameter(0).getUnspecifiedType().(ReferenceType).getBaseType()
       instanceof StdPairClass
   }
 

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ class StdPairCopyishConstructor extends Constructor, TaintFunction {`
`20`	`20`	`StdPairCopyishConstructor() {`
`21`	`21`	`this.getDeclaringType() instanceof StdPairClass and`
`22`	`22`	`this.getNumberOfParameters() = 1 and`
`23`		`- this.getParameter(0).getUnspecifiedType().(ReferenceType).getBaseType().getUnspecifiedType()`
	`23`	`+ this.getParameter(0).getUnspecifiedType().(ReferenceType).getBaseType()`
`24`	`24`	`instanceof StdPairClass`
`25`	`25`	`}`
`26`	`26`