JS: isAngularTemplateAttributeName

asgerf · asgerf · commit 9b99f56d4410 · 2021-01-18T12:16:13.000Z
diff --git a/javascript/extractor/src/com/semmle/js/extractor/HTMLExtractor.java b/javascript/extractor/src/com/semmle/js/extractor/HTMLExtractor.java
@@ -93,7 +93,7 @@ public void handleElement(Element elt) {
 
             String source = attr.getValue();
             RowColumnVector valueStart = attr.getValueSegment().getRowColumnVector();
-            if (JS_ATTRIBUTE.matcher(attr.getName()).matches()) {
+            if (JS_ATTRIBUTE.matcher(attr.getName()).matches() || isAngularTemplateAttributeName(attr.getName())) {
               snippetLoC =
                   extractSnippet(
                       2,
@@ -128,6 +128,12 @@ public LoCInfo getLoCInfo() {
     }
   }
 
+  private boolean isAngularTemplateAttributeName(String name) {
+    return name.startsWith("[") && name.endsWith("]") ||
+        name.startsWith("(") && name.endsWith(")") ||
+        name.startsWith("*ng");
+  }
+
   /** List of HTML attributes whose value is interpreted as JavaScript. */
   private static final Pattern JS_ATTRIBUTE =
       Pattern.compile(
