Kotlin: Add some TODO comments

igfoo · igfoo · commit 9c4c559ab2c5 · 2022-05-10T19:51:08.000+01:00
diff --git a/java/kotlin-extractor/src/main/kotlin/KotlinSourceFileExtractor.kt b/java/kotlin-extractor/src/main/kotlin/KotlinSourceFileExtractor.kt
@@ -10,6 +10,7 @@ import org.jetbrains.kotlin.ir.types.IrSimpleType
 import org.jetbrains.kotlin.ir.util.packageFqName
 import org.jetbrains.kotlin.ir.util.IdSignature
 
+// TODO: Is a separate class for this, vs KotlinFileExtractor, useful?
 class KotlinSourceFileExtractor(
     logger: FileLogger,
     tw: FileTrapWriter,
@@ -30,6 +31,8 @@ class KotlinSourceFileExtractor(
         val pkgId = extractPackage(pkg)
         tw.writeHasLocation(id, locId)
         tw.writeCupackage(id, pkgId)
+        // TODO: Use of fileClass looks like it will defeat laziness since 3502e5c5720e981c913bdafdccf7f5e9237be070
+        // TODO: Consistency query for unused file classes
         file.declarations.map { extractDeclaration(it, fileClass) }
         CommentExtractor(this).extract()
     }
diff --git a/java/kotlin-extractor/src/main/kotlin/KotlinUsesExtractor.kt b/java/kotlin-extractor/src/main/kotlin/KotlinUsesExtractor.kt
@@ -79,6 +79,7 @@ open class KotlinUsesExtractor(
 
         val newLogger = FileLogger(logger.logCounter, newTrapWriter)
 
+        // TODO: Conditionally KotlinSourceFileExtractor?
         return KotlinFileExtractor(newLogger, newTrapWriter, dependencyCollector, externalClassExtractor, primitiveTypeMapping, pluginContext)
     }
 

Original file line number	Diff line number	Diff line change
`@@ -79,6 +79,7 @@ open class KotlinUsesExtractor(`
`79`	`79`
`80`	`80`	`val newLogger = FileLogger(logger.logCounter, newTrapWriter)`
`81`	`81`
	`82`	`+ // TODO: Conditionally KotlinSourceFileExtractor?`
`82`	`83`	`return KotlinFileExtractor(newLogger, newTrapWriter, dependencyCollector, externalClassExtractor, primitiveTypeMapping, pluginContext)`
`83`	`84`	`}`
`84`	`85`