CPP: Tag the JPL_C LOC-2 queries.

geoffw0 · geoffw0 · commit 9cc39ae875f1 · 2018-11-22T16:31:08.000Z
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 03/ExitNonterminatingLoop.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 03/ExitNonterminatingLoop.ql
@@ -4,6 +4,7 @@
  * @kind problem
  * @id cpp/jpl-c/exit-nonterminating-loop
  * @problem.severity warning
+ * @tags correctness
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 03/LoopBounds.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 03/LoopBounds.ql
@@ -5,6 +5,7 @@
  * @kind problem
  * @id cpp/jpl-c/loop-bounds
  * @problem.severity warning
+ * @tags correctness
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 04/Recursion.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 04/Recursion.ql
@@ -4,6 +4,9 @@
  * @kind problem
  * @id cpp/jpl-c/recursion
  * @problem.severity warning
+ * @tags maintainability
+ *       readability
+ *       testability
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 05/HeapMemory.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 05/HeapMemory.ql
@@ -3,7 +3,8 @@
  * @description Dynamic memory allocation (using malloc() or calloc()) should be confined to the initialization routines of a program.
  * @kind problem
  * @id cpp/jpl-c/heap-memory
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags resources
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 07/ThreadSafety.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 07/ThreadSafety.ql
@@ -4,6 +4,8 @@
  * @kind problem
  * @id cpp/jpl-c/thread-safety
  * @problem.severity warning
+ * @tags correctness
+ *       concurrency
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 09/AvoidNestedSemaphores.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 09/AvoidNestedSemaphores.ql
@@ -4,6 +4,8 @@
  * @kind problem
  * @id cpp/jpl-c/avoid-nested-semaphores
  * @problem.severity warning
+ * @tags correctness
+ *       concurrency
  */
 
 import Semaphores
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 09/AvoidSemaphores.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 09/AvoidSemaphores.ql
@@ -3,7 +3,8 @@
  * @description The use of semaphores or locks to access shared data should be avoided.
  * @kind problem
  * @id cpp/jpl-c/avoid-semaphores
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags concurrency
  */
 
 import Semaphores
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 09/OutOfOrderLocks.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 09/OutOfOrderLocks.ql
@@ -4,6 +4,8 @@
  * @kind problem
  * @id cpp/jpl-c/out-of-order-locks
  * @problem.severity warning
+ * @tags correctness
+ *       concurrency
  */
 
 import Semaphores
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 09/ReleaseLocksWhenAcquired.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 09/ReleaseLocksWhenAcquired.ql
@@ -4,6 +4,8 @@
  * @kind problem
  * @id cpp/jpl-c/release-locks-when-acquired
  * @problem.severity warning
+ * @tags correctness
+ *       concurrency
  */
 
 import Semaphores
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 11/SimpleControlFlowGoto.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 11/SimpleControlFlowGoto.ql
@@ -4,6 +4,8 @@
  * @kind problem
  * @id cpp/jpl-c/simple-control-flow-goto
  * @problem.severity warning
+ * @tags maintainability
+ *       readability
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 11/SimpleControlFlowJmp.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 11/SimpleControlFlowJmp.ql
@@ -4,6 +4,9 @@
  * @kind problem
  * @id cpp/jpl-c/simple-control-flow-jmp
  * @problem.severity warning
+ * @tags correctness
+ *       portability
+ *       readability
  */
 
 import cpp
diff --git a/cpp/ql/src/JPL_C/LOC-2/Rule 12/EnumInitialization.ql b/cpp/ql/src/JPL_C/LOC-2/Rule 12/EnumInitialization.ql
@@ -3,7 +3,9 @@
  * @description In an enumerator list, the = construct should not be used to explicitly initialize members other than the first, unless all items are explicitly initialized. An exception is the pattern to use the last element of an enumerator list to get the number of possible values.
  * @kind problem
  * @id cpp/jpl-c/enum-initialization
- * @problem.severity warning
+ * @problem.severity recommendation
+ * @tags maintainability
+ *       readability
  */
 import cpp
 
