C++: Prefer matches to regexpMatch.

geoffw0 · geoffw0 · commit 9e75f53798d9 · 2021-05-17T15:35:19.000+01:00
diff --git a/cpp/ql/src/semmle/code/cpp/security/Encryption.qll b/cpp/ql/src/semmle/code/cpp/security/Encryption.qll
@@ -68,7 +68,7 @@ predicate isInsecureEncryption(string name) {
  */
 bindingset[name]
 predicate isEncryptionAdditionalEvidence(string name) {
-  name.toUpperCase().regexpMatch(".*(CRYPT|CODE|CODING|CBC|KEY).*")
+  name.toUpperCase().matches("%" + ["CRYPT", "CODE", "CODING", "CBC", "KEY"] + "%")
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ predicate isInsecureEncryption(string name) {`
`68`	`68`	`*/`
`69`	`69`	`bindingset[name]`
`70`	`70`	`predicate isEncryptionAdditionalEvidence(string name) {`
`71`		`- name.toUpperCase().regexpMatch(".(CRYPT\|CODE\|CODING\|CBC\|KEY).")`
	`71`	`+ name.toUpperCase().matches("%" + ["CRYPT", "CODE", "CODING", "CBC", "KEY"] + "%")`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`/**`