Python: Highlight shortcomings of hashlib.new modeling

RasmusWL · RasmusWL · commit 9e91f3a3412c · 2021-11-04T15:29:40.000+01:00
diff --git a/python/ql/test/library-tests/frameworks/stdlib/test_md5.py b/python/ql/test/library-tests/frameworks/stdlib/test_md5.py
@@ -27,3 +27,12 @@
 hasher.update(b"secret") # $ CryptographicOperation CryptographicOperationInput=b"secret" CryptographicOperationAlgorithm=MD5
 hasher.update(b" message") # $ CryptographicOperation CryptographicOperationInput=b" message" CryptographicOperationAlgorithm=MD5
 print(hasher.hexdigest())
+
+
+def foo(arg):
+    hasher = hashlib.new(arg)
+    hasher.update(b"secret") # $ MISSING: CryptographicOperation CryptographicOperationInput=b"secret" CryptographicOperationAlgorithm=MD5
+    hasher.update(b" message") # $ MISSING: CryptographicOperation CryptographicOperationInput=b" message" CryptographicOperationAlgorithm=MD5
+    print(hasher.hexdigest())
+
+foo("md5")
