Merge pull request #4739 from RasmusWL/recrete-regex-fp

tausbn · web-flow · commit 9eeaceac2a86 · 2020-12-02T13:01:47.000+01:00
Python: Add regex FP with + for flags
diff --git a/python/ql/test/library-tests/regex/Mode.expected b/python/ql/test/library-tests/regex/Mode.expected
@@ -7,4 +7,5 @@
 | 50 | VERBOSE |
 | 51 | UNICODE |
 | 52 | UNICODE |
-| 64 | MULTILINE |
+| 56 | VERBOSE |
+| 68 | MULTILINE |
diff --git a/python/ql/test/library-tests/regex/test.py b/python/ql/test/library-tests/regex/test.py
@@ -1,5 +1,5 @@
 import re
-#            0123456789ABCDEF  
+#            0123456789ABCDEF
 re.compile(r'012345678')
 re.compile(r'(\033|~{)')
 re.compile(r'\A[+-]?\d+')
@@ -50,6 +50,10 @@
 re.compile("", flags=re.VERBOSE|re.IGNORECASE)
 re.search("", None, re.UNICODE)
 x = re.search("", flags=re.UNICODE)
+# using addition for flags was reported as FP in https://github.com/github/codeql/issues/4707
+re.compile("", re.VERBOSE+re.DOTALL) # TODO: Currently not recognized with Mode.ql
+# re.X is an alias for re.VERBOSE
+re.compile("", re.X)
 
 #empty choice
 re.compile(r'|x')
