Java: Introduce column validation for negative summaries.

michaelnebel · michaelnebel · commit 9f9129d3c935 · 2022-08-24T09:58:52.000+02:00
diff --git a/java/ql/lib/semmle/code/java/dataflow/CsvValidation.qll b/java/ql/lib/semmle/code/java/dataflow/CsvValidation.qll
@@ -89,6 +89,8 @@ private string getInvalidModelColumnCount() {
     sinkModel(row) and expect = 9 and pred = "sink"
     or
     summaryModel(row) and expect = 10 and pred = "summary"
+    or
+    negativeSummaryModel(row) and expect = 5 and pred = "negative summary"
   |
     exists(int cols |
       cols = 1 + max(int n | exists(row.splitAt(";", n))) and

Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,8 @@ private string getInvalidModelColumnCount() {`
`89`	`89`	`sinkModel(row) and expect = 9 and pred = "sink"`
`90`	`90`	`or`
`91`	`91`	`summaryModel(row) and expect = 10 and pred = "summary"`
	`92`	`+ or`
	`93`	`+ negativeSummaryModel(row) and expect = 5 and pred = "negative summary"`
`92`	`94`	`\|`
`93`	`95`	`exists(int cols \|`
`94`	`96`	`cols = 1 + max(int n \| exists(row.splitAt(";", n))) and`