C++: Improve ErrorExpr documentation to match current practise

jketema · jketema · commit a27b1ee33a89 · 2022-07-29T09:08:56.000+02:00
diff --git a/cpp/ql/lib/semmle/code/cpp/exprs/Expr.qll b/cpp/ql/lib/semmle/code/cpp/exprs/Expr.qll
@@ -596,9 +596,12 @@ class ParenthesisExpr extends Conversion, @parexpr {
 }
 
 /**
- * A C/C++ expression that has not been resolved.
+ * A C/C++ expression that could not be resolved, or that can no longer be
+ * represented due to a database upgrade or downgrade.
  *
- * It is assigned `ErroneousType` as its type.
+ * If the expression could not be resolved, it has type `ErroneousType`. In the
+ * case of a database upgrade or downgrade, the original type from before the
+ * upgrade or downgrade is kept if that type can be represented.
  */
 class ErrorExpr extends Expr, @errorexpr {
   override string toString() { result = "<error expr>" }

Original file line number	Diff line number	Diff line change
`@@ -596,9 +596,12 @@ class ParenthesisExpr extends Conversion, @parexpr {`
`596`	`596`	`}`
`597`	`597`
`598`	`598`	`/**`
`599`		`- * A C/C++ expression that has not been resolved.`
	`599`	`+ * A C/C++ expression that could not be resolved, or that can no longer be`
	`600`	`+ * represented due to a database upgrade or downgrade.`
`600`	`601`	`*`
`601`		- * It is assigned `ErroneousType` as its type.
	`602`	+ * If the expression could not be resolved, it has type `ErroneousType`. In the
	`603`	`+ * case of a database upgrade or downgrade, the original type from before the`
	`604`	`+ * upgrade or downgrade is kept if that type can be represented.`
`602`	`605`	`*/`
`603`	`606`	`class ErrorExpr extends Expr, @errorexpr {`
`604`	`607`	`override string toString() { result = "<error expr>" }`