Apply suggestions from code review

atorralba · Marcono1234 · atorralba · commit a2e9c2f4abc3 · 2021-10-05T09:18:47.000+02:00
Co-authored-by: Marcono1234 &lt;Marcono1234@users.noreply.github.com&gt;
diff --git a/java/ql/src/semmle/code/java/frameworks/Mail.qll b/java/ql/src/semmle/code/java/frameworks/Mail.qll
@@ -20,7 +20,7 @@ class MailSessionGetInstanceMethod extends Method {
 }
 
 /**
- * A subtype of the class `org.apache.commons.mail.Mail`
+ * A subtype of the class `org.apache.commons.mail.Email`
  */
 class ApacheEmail extends Class {
   ApacheEmail() { this.getASupertype*().hasQualifiedName("org.apache.commons.mail", "Email") }
diff --git a/java/ql/src/semmle/code/java/security/Mail.qll b/java/ql/src/semmle/code/java/security/Mail.qll
@@ -56,9 +56,7 @@ predicate hasSslCertificateCheck(VarAccess va) {
 private string getStringValue(Expr expr) {
   result = expr.(CompileTimeConstantExpr).getStringValue()
   or
-  result = getStringValue(expr.(AddExpr).getLeftOperand())
-  or
-  result = getStringValue(expr.(AddExpr).getRightOperand())
+  result = getStringValue(expr.(AddExpr).getAnOperand())
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ class MailSessionGetInstanceMethod extends Method {`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`/**`
`23`		- * A subtype of the class `org.apache.commons.mail.Mail`
	`23`	+ * A subtype of the class `org.apache.commons.mail.Email`
`24`	`24`	`*/`
`25`	`25`	`class ApacheEmail extends Class {`
`26`	`26`	`ApacheEmail() { this.getASupertype*().hasQualifiedName("org.apache.commons.mail", "Email") }`