Ruby: redundant check is implied by isToplevel()

asgerf · asgerf · commit a59a404752ca · 2023-03-23T14:28:09.000+01:00
diff --git a/ruby/ql/lib/codeql/ruby/ast/internal/Module.qll b/ruby/ql/lib/codeql/ruby/ast/internal/Module.qll
@@ -407,7 +407,6 @@ private module ResolveImpl {
    */
   string getAnAssumedGlobalConst() {
     exists(ConstantAccess access |
-      not exists(access.getScopeExpr()) and
       result = access.getName() and
       isToplevel(access)
     )

Original file line number	Diff line number	Diff line change
`@@ -407,7 +407,6 @@ private module ResolveImpl {`
`407`	`407`	`*/`
`408`	`408`	`string getAnAssumedGlobalConst() {`
`409`	`409`	`exists(ConstantAccess access \|`
`410`		`- not exists(access.getScopeExpr()) and`
`411`	`410`	`result = access.getName() and`
`412`	`411`	`isToplevel(access)`
`413`	`412`	`)`