CPP: Resolve remaining comments from the original PR.

geoffw0 · geoffw0 · commit a5d2fbd25d9c · 2019-11-13T09:46:09.000Z
diff --git a/cpp/ql/src/semmle/code/cpp/exprs/Assignment.qll b/cpp/ql/src/semmle/code/cpp/exprs/Assignment.qll
@@ -209,9 +209,9 @@ class AssignPointerSubExpr extends AssignOperation, @assignpsubexpr {
 }
 
 /**
- * A C++ variable declaration inside the conditional expression of a `while` or `if`
- * compound statement.  Declaring a variable this way narrows its lifetime and scope
- * to be strictly the compound statement itself.  For example:
+ * A C++ variable declaration inside the conditional expression of a `while`, `if` or
+ * `for` compound statement.  Declaring a variable this way narrows its lifetime and
+ * scope to be strictly the compound statement itself.  For example:
  * ```
  * extern int x, y;
  * if (bool c = x < y) { do_something_with(c); }
diff --git a/cpp/ql/src/semmle/code/cpp/exprs/Expr.qll b/cpp/ql/src/semmle/code/cpp/exprs/Expr.qll
@@ -1064,7 +1064,7 @@ private Expr getStmtResultExpr(Stmt stmt) {
 }
 
 /**
- * The C++ `this` pointer.
+ * The C++ `this` expression.
  */
 class ThisExpr extends Expr, @thisaccess {
   override string toString() { result = "this" }

Original file line number	Diff line number	Diff line change
`@@ -1064,7 +1064,7 @@ private Expr getStmtResultExpr(Stmt stmt) {`
`1064`	`1064`	`}`
`1065`	`1065`
`1066`	`1066`	`/**`
`1067`		- * The C++ `this` pointer.
	`1067`	+ * The C++ `this` expression.
`1068`	`1068`	`*/`
`1069`	`1069`	`class ThisExpr extends Expr, @thisaccess {`
`1070`	`1070`	`override string toString() { result = "this" }`