Use FlowSummaryImpl::Private::summaryParameterNodeRange

smowton · smowton · commit a5e5a5780ddf · 2023-04-12T14:15:54.000+01:00
diff --git a/go/ql/lib/semmle/go/dataflow/internal/DataFlowNodes.qll b/go/ql/lib/semmle/go/dataflow/internal/DataFlowNodes.qll
@@ -11,9 +11,7 @@ private newtype TNode =
   MkSsaNode(SsaDefinition ssa) or
   MkGlobalFunctionNode(Function f) or
   MkSummarizedParameterNode(SummarizedCallable c, int i) {
-    i in [0 .. c.getType().getNumParameter() - 1]
-    or
-    c.asFunction() instanceof Method and i = -1
+    FlowSummaryImpl::Private::summaryParameterNodeRange(c, i)
   } or
   MkSummaryInternalNode(SummarizedCallable c, FlowSummaryImpl::Private::SummaryNodeState state) {
     FlowSummaryImpl::Private::summaryNodeRange(c, state)
