C++: Fix 'begin'/'base' confusion.

MathiasVP · MathiasVP · commit a7ee27ec2255 · 2023-07-21T10:20:24.000+01:00
diff --git a/cpp/ql/lib/semmle/code/cpp/security/InvalidPointerDereference/InvalidPointerToDereference.qll b/cpp/ql/lib/semmle/code/cpp/security/InvalidPointerDereference/InvalidPointerToDereference.qll
@@ -30,7 +30,7 @@
  * any dataflow node `n` such that `addr <= sink.asInstruction() + delta2` for some `delta2`. We call the instruction that
  * consumes the address operand the "operation".
  *
- * For example, consider the flow from `begin + size` to `end` above. The sink is `end` on line 3 because that is a dataflow
+ * For example, consider the flow from `base + size` to `end` above. The sink is `end` on line 3 because that is a dataflow
  * node whose underlying instruction non-strictly upper bounds the address operand `p` in `use(*p)`. The load attached to `*p`
  * is the "operation". To ensure that the path makes intuitive sense, we only pick operations that are control-flow reachable
  * from the dereference sink.

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@`
`30`	`30`	* any dataflow node `n` such that `addr <= sink.asInstruction() + delta2` for some `delta2`. We call the instruction that
`31`	`31`	`* consumes the address operand the "operation".`
`32`	`32`	`*`
`33`		- * For example, consider the flow from `begin + size` to `end` above. The sink is `end` on line 3 because that is a dataflow
	`33`	+ * For example, consider the flow from `base + size` to `end` above. The sink is `end` on line 3 because that is a dataflow
`34`	`34`	* node whose underlying instruction non-strictly upper bounds the address operand `p` in `use(p)`. The load attached to `p`
`35`	`35`	`* is the "operation". To ensure that the path makes intuitive sense, we only pick operations that are control-flow reachable`
`36`	`36`	`* from the dereference sink.`