Add comments about how the future promotion should go

luchua-bc · luchua-bc · commit a83ddd66eb51 · 2020-11-26T17:41:46.000Z
diff --git a/java/ql/src/experimental/Security/CWE/CWE-312/CleartextStorageSharedPrefs.ql b/java/ql/src/experimental/Security/CWE/CWE-312/CleartextStorageSharedPrefs.ql
@@ -127,6 +127,10 @@ class SharedPreferencesEditor extends MethodAccess {
   }
 }
 
+/**
+ * Flow from sensitive expressions to shared preferences.
+ * Note it can be merged into `SensitiveSourceFlowConfig` of `Security/CWE/CWE-312/SensitiveStorage.qll` when this query is promoted from the experimental directory.
+ */
 private class SensitiveSharedPrefsFlowConfig extends TaintTracking::Configuration {
   SensitiveSharedPrefsFlowConfig() {
     this = "CleartextStorageSharedPrefs::SensitiveSharedPrefsFlowConfig"

Original file line number	Diff line number	Diff line change
`@@ -127,6 +127,10 @@ class SharedPreferencesEditor extends MethodAccess {`
`127`	`127`	`}`
`128`	`128`	`}`
`129`	`129`
	`130`	`+/**`
	`131`	`+ * Flow from sensitive expressions to shared preferences.`
	`132`	+ * Note it can be merged into `SensitiveSourceFlowConfig` of `Security/CWE/CWE-312/SensitiveStorage.qll` when this query is promoted from the experimental directory.
	`133`	`+ */`
`130`	`134`	`private class SensitiveSharedPrefsFlowConfig extends TaintTracking::Configuration {`
`131`	`135`	`SensitiveSharedPrefsFlowConfig() {`
`132`	`136`	`this = "CleartextStorageSharedPrefs::SensitiveSharedPrefsFlowConfig"`