change the default sorting order for print children to be location based

erik-krogh · erik-krogh · commit ab10c28cc4d7 · 2020-10-15T09:53:52.000+02:00
diff --git a/javascript/ql/src/semmle/javascript/PrintAst.qll b/javascript/ql/src/semmle/javascript/PrintAst.qll
@@ -200,7 +200,18 @@ private module PrintJavaScript {
      * Gets the `i`th child of `element`.
      * Can be overriden in subclasses to get more specific behavior for `getChild()`.
      */
-    ASTNode getChildNode(int childIndex) { result = element.getChild(childIndex) }
+    ASTNode getChildNode(int childIndex) { result = getLocationSortedChild(element, childIndex) }
+  }
+
+  private ASTNode getLocationSortedChild(ASTNode parent, int i) {
+    result =
+      rank[i](ASTNode child, int childIndex |
+        child = parent.getChild(childIndex)
+      |
+        child
+        order by
+          child.getLocation().getStartLine(), child.getLocation().getStartColumn(), childIndex
+      )
   }
 
   /**
