Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit ae8ecc8

Browse files
calumgrantcalumgrant
committed
C#: Address review comments.
1 parent fc8eccf commit ae8ecc8

7 files changed

Lines changed: 11 additions & 25 deletions

File tree

‎csharp/ql/src/Diagnostics/CompilerError.qhelp‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,7 @@
55

66
<overview>
77
<p>
8-
This is an internal query that finds all compilation errors reported by the C# compiler.</p>
8+
This is an internal query that finds all compilation errors reported by the C# compiler used by the C# extractor.</p>
99
</overview>
1010

11-
<recommendation>
12-
<p>
13-
Fix the cause of the compilation error.
14-
</p>
15-
</recommendation>
16-
1711
</qhelp>

‎csharp/ql/src/Diagnostics/CompilerError.ql‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
* @description A compilation error can cause extraction problems, and could lead to inaccurate results.
44
* @kind problem
55
* @problem.severity recommendation
6-
* @precision medium
6+
* @precision high
77
* @id cs/compilation-error
8-
* @tags internal
8+
* @tags internal non-attributable
99
*/
1010

1111
import csharp

‎csharp/ql/src/Diagnostics/CompilerMessage.qhelp‎

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,9 @@
55

66
<overview>
77
<p>
8-
This is an internal query that finds all messages reported by the compiler. This may include both compiler errors and
9-
compiler warnings. Compiler errors can lead to inaccurate results and should be fixed.
8+
This is an internal query that finds all messages reported by the C# compiler used by the C# extractor. This may include both compiler errors and
9+
compiler warnings.
1010
</p>
1111
</overview>
1212

13-
<recommendation>
14-
<p>
15-
Fix the cause of the compilation error.
16-
</p>
17-
</recommendation>
18-
1913
</qhelp>

‎csharp/ql/src/Diagnostics/CompilerMessage.ql‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
* @description A message emitted by the compiler, including warnings and errors.
44
* @kind problem
55
* @problem.severity recommendation
6-
* @precision medium
6+
* @precision high
77
* @id cs/compilation-message
8-
* @tags internal
8+
* @tags internal non-attributable
99
*/
1010

1111
import csharp

‎csharp/ql/src/Diagnostics/ExtractorError.ql‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
* to inaccurate results.
66
* @kind problem
77
* @problem.severity recommendation
8-
* @precision medium
8+
* @precision high
99
* @id cs/extraction-error
10-
* @tags internal
10+
* @tags internal non-attributable
1111
*/
1212

1313
import csharp

‎csharp/ql/src/Diagnostics/ExtractorMessage.qhelp‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,4 @@ Extractor errors can lead to inaccurate results.
1313
</p>
1414
</overview>
1515

16-
<recommendation></recommendation>
17-
1816
</qhelp>

‎csharp/ql/src/Diagnostics/ExtractorMessage.ql‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
* @description An error message reported by the extractor. This could lead to inaccurate results.
44
* @kind problem
55
* @problem.severity recommendation
6-
* @precision medium
6+
* @precision high
77
* @id cs/extraction-message
8-
* @tags internal
8+
* @tags internal non-attributable
99
*/
1010

1111
import csharp

0 commit comments

Comments
 (0)