C#: Fix LGTM warnings

calumgrant · calumgrant · commit aecc9e2a5796 · 2019-05-24T13:49:05.000+01:00
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/VariableDeclaration.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/VariableDeclaration.cs
@@ -75,7 +75,6 @@ public static Expression CreateParenthesized(Context cx, VarPatternSyntax varPat
                             {
                                 var decl = Create(cx, variable, Type.Create(cx, local.Type), true, tuple, child0++);
                                 var id = single.Identifier;
-                                var declSymbol = cx.Model(single).GetDeclaredSymbol(single);
                                 var location = cx.Create(id.GetLocation());
                                 LocalVariable.Create(cx, local, decl, true, location);
                             }
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/Statements/Case.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/Statements/Case.cs
@@ -75,7 +75,7 @@ private void PopulatePattern(PatternSyntax pattern, TypeSyntax optionalType, Syn
 
             switch (designation)
             {
-                case SingleVariableDesignationSyntax single:
+                case SingleVariableDesignationSyntax _:
                     if (cx.Model(pattern).GetDeclaredSymbol(designation) is ILocalSymbol symbol)
                     {
                         var type = Type.Create(cx, symbol.Type);
@@ -92,7 +92,7 @@ private void PopulatePattern(PatternSyntax pattern, TypeSyntax optionalType, Syn
                 case null:
                     break;
                 case ParenthesizedVariableDesignationSyntax paren:
-                    Expressions.VariableDeclaration.CreateParenthesized(cx, pattern as VarPatternSyntax, paren, this, 0);
+                    Expressions.VariableDeclaration.CreateParenthesized(cx, (VarPatternSyntax)pattern, paren, this, 0);
                     break;
                 default:
                     throw new InternalError(pattern, "Unhandled designation in case statement");

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,6 @@ public static Expression CreateParenthesized(Context cx, VarPatternSyntax varPat`
`75`	`75`	`{`
`76`	`76`	`var decl = Create(cx, variable, Type.Create(cx, local.Type), true, tuple, child0++);`
`77`	`77`	`var id = single.Identifier;`
`78`		`- var declSymbol = cx.Model(single).GetDeclaredSymbol(single);`
`79`	`78`	`var location = cx.Create(id.GetLocation());`
`80`	`79`	`LocalVariable.Create(cx, local, decl, true, location);`
`81`	`80`	`}`