Kotlin: Apply review feedback

igfoo · igfoo · commit af3bc4f44dd6 · 2022-05-10T19:51:31.000+01:00
diff --git a/java/ql/lib/semmle/code/java/ControlFlowGraph.qll b/java/ql/lib/semmle/code/java/ControlFlowGraph.qll
@@ -623,8 +623,6 @@ private module ControlFlowGraphImpl {
     or
     result = first(n.(InstanceOfExpr).getExpr())
     or
-    result = first(n.(NotInstanceOfExpr).getExpr())
-    or
     result = first(n.(SynchronizedStmt).getExpr())
     or
     result = n and
diff --git a/java/ql/lib/semmle/code/java/Expr.qll b/java/ql/lib/semmle/code/java/Expr.qll
@@ -2357,7 +2357,7 @@ class Argument extends Expr {
       tgt.getParameter(varargsParamPos).isVarargs() and
       arrayindex = pos - varargsParamPos and
       arrayindex >= 0 and
-      arrayindex <= (call.getNumArgument() - tgt.getNumberOfParameters())
+      arrayindex <= call.getNumArgument() - tgt.getNumberOfParameters()
     )
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -2357,7 +2357,7 @@ class Argument extends Expr {`
`2357`	`2357`	`tgt.getParameter(varargsParamPos).isVarargs() and`
`2358`	`2358`	`arrayindex = pos - varargsParamPos and`
`2359`	`2359`	`arrayindex >= 0 and`
`2360`		`- arrayindex <= (call.getNumArgument() - tgt.getNumberOfParameters())`
	`2360`	`+ arrayindex <= call.getNumArgument() - tgt.getNumberOfParameters()`
`2361`	`2361`	`)`
`2362`	`2362`	`}`
`2363`	`2363`	`}`