Update cpp/ql/src/Likely Bugs/Memory Management/AllocaInLoop.ql

jketema · MathiasVP · web-flow · commit b10ed976cc04 · 2022-12-13T10:57:34.000+01:00
Co-authored-by: Mathias Vorreiter Pedersen &lt;mathiasvp@github.com&gt;
diff --git a/cpp/ql/src/Likely Bugs/Memory Management/AllocaInLoop.ql b/cpp/ql/src/Likely Bugs/Memory Management/AllocaInLoop.ql
@@ -221,7 +221,7 @@ class LoopWithAlloca extends Stmt {
   private int getAControllingVarInitialValue(Variable var, DataFlow::Node source) {
     source = this.getAPrecedingDef(var) and
     (
-      result = getExpr(source).(Expr).getValue().toInt()
+      result = getExpr(source).getValue().toInt()
       or
       result = getExpr(source).(Assignment).getRValue().getValue().toInt()
     )

Original file line number	Diff line number	Diff line change
`@@ -221,7 +221,7 @@ class LoopWithAlloca extends Stmt {`
`221`	`221`	`private int getAControllingVarInitialValue(Variable var, DataFlow::Node source) {`
`222`	`222`	`source = this.getAPrecedingDef(var) and`
`223`	`223`	`(`
`224`		`- result = getExpr(source).(Expr).getValue().toInt()`
	`224`	`+ result = getExpr(source).getValue().toInt()`
`225`	`225`	`or`
`226`	`226`	`result = getExpr(source).(Assignment).getRValue().getValue().toInt()`
`227`	`227`	`)`