C++: Add forgotten test annotation in for cpp/invalid-pointer-deref test

jketema · jketema · commit b1c1513a1033 · 2023-05-17T11:21:09.000+02:00
diff --git a/cpp/ql/test/experimental/query-tests/Security/CWE/CWE-193/pointer-deref/test.cpp b/cpp/ql/test/experimental/query-tests/Security/CWE/CWE-193/pointer-deref/test.cpp
@@ -304,7 +304,7 @@ void test21() {
   void** xs = new void*[n];
 
   for (int i = 0; i < n; i += 2) {
-    xs[i] = test21_get(i);
-    xs[i+1] = test21_get(i+1);
+    xs[i] = test21_get(i); // GOOD
+    xs[i+1] = test21_get(i+1); // GOOD [FALSE POSITIVE]
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -304,7 +304,7 @@ void test21() {`
`304`	`304`	`void** xs = new void*[n];`
`305`	`305`
`306`	`306`	`for (int i = 0; i < n; i += 2) {`
`307`		`- xs[i] = test21_get(i);`
`308`		`- xs[i+1] = test21_get(i+1);`
	`307`	`+ xs[i] = test21_get(i); // GOOD`
	`308`	`+ xs[i+1] = test21_get(i+1); // GOOD [FALSE POSITIVE]`
`309`	`309`	`}`
`310`	`310`	`}`