JS: recognize res.sendfile as alias for res.sendFile in Express

asger-semmle · asger-semmle · commit b20fd3c0843c · 2018-09-17T11:31:10.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/frameworks/Express.qll b/javascript/ql/src/semmle/javascript/frameworks/Express.qll
@@ -785,7 +785,8 @@ module Express {
     override MethodCallExpr astNode;
 
     ResponseSendFileAsFileSystemAccess() {
-      asExpr().(MethodCallExpr).calls(any(ResponseExpr res), "sendFile")
+      exists (string name | name = "sendFile" or name = "sendfile" |
+        asExpr().(MethodCallExpr).calls(any(ResponseExpr res), name))
     }
 
     override DataFlow::Node getAPathArgument() {

Original file line number	Diff line number	Diff line change
`@@ -785,7 +785,8 @@ module Express {`
`785`	`785`	`override MethodCallExpr astNode;`
`786`	`786`
`787`	`787`	`ResponseSendFileAsFileSystemAccess() {`
`788`		`- asExpr().(MethodCallExpr).calls(any(ResponseExpr res), "sendFile")`
	`788`	`+ exists (string name \| name = "sendFile" or name = "sendfile" \|`
	`789`	`+ asExpr().(MethodCallExpr).calls(any(ResponseExpr res), name))`
`789`	`790`	`}`
`790`	`791`
`791`	`792`	`override DataFlow::Node getAPathArgument() {`