C++: isConstant() -> exists(getValue())

jbj · jbj · commit b3f46d757aa8 · 2019-01-15T19:03:49.000+01:00
This code was clearly using `isConstant` as an indirect way of checking
whether `getValue` would have a result. That's no longer valid, so I
changed it to check `getValue` directly.
diff --git a/cpp/ql/src/Likely Bugs/Likely Typos/LogicalExprCouldBeSimplified.ql b/cpp/ql/src/Likely Bugs/Likely Typos/LogicalExprCouldBeSimplified.ql
@@ -43,7 +43,7 @@ string comparisonOnLiterals(ComparisonOperation op) {
   simple(op.getLeftOperand()) and
   simple(op.getRightOperand()) and
   not op.getAnOperand().isInMacroExpansion() and
-  if op.isConstant()
+  if exists(op.getValue())
   then result = "This comparison involves two literals and is always " + op.getValue() + "."
   else result = "This comparison involves two literals and should be simplified."
 }

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ string comparisonOnLiterals(ComparisonOperation op) {`
`43`	`43`	`simple(op.getLeftOperand()) and`
`44`	`44`	`simple(op.getRightOperand()) and`
`45`	`45`	`not op.getAnOperand().isInMacroExpansion() and`
`46`		`- if op.isConstant()`
	`46`	`+ if exists(op.getValue())`
`47`	`47`	`then result = "This comparison involves two literals and is always " + op.getValue() + "."`
`48`	`48`	`else result = "This comparison involves two literals and should be simplified."`
`49`	`49`	`}`