JS: Ignore obvious Array.prototype.concat calls

asgerf · asgerf · commit b4df03767d8b · 2020-02-04T16:36:41.000Z
diff --git a/javascript/ql/src/semmle/javascript/StringConcatenation.qll b/javascript/ql/src/semmle/javascript/StringConcatenation.qll
@@ -55,6 +55,13 @@ module StringConcatenation {
     exists(DataFlow::MethodCallNode call |
       node = call and
       call.getMethodName() = "concat" and
+      not (
+        exists(DataFlow::ArrayCreationNode array |
+          array.flowsTo(call.getAnArgument()) or array.flowsTo(call.getReceiver())
+        )
+        or
+        DataFlow::reflectiveCallNode(_) = call
+      ) and
       (
         n = 0 and
         result = call.getReceiver()
diff --git a/javascript/ql/test/library-tests/StringConcatenation/tst.js b/javascript/ql/test/library-tests/StringConcatenation/tst.js
@@ -95,3 +95,7 @@ function concatCall() {
   x = x.concat('two', 'three');
   return x;
 }
+
+function arrayConcat(a, b) {
+  return [].concat(a, b);
+}
