C++: Improve ReturnStackAllocatedMemory alert msg

jbj · jbj · commit b9236d216f81 · 2019-02-21T11:20:25.000+01:00
diff --git a/cpp/ql/src/Likely Bugs/Memory Management/ReturnStackAllocatedMemory.ql b/cpp/ql/src/Likely Bugs/Memory Management/ReturnStackAllocatedMemory.ql
@@ -46,4 +46,4 @@ where
       )
     )
   )
-select r, "May return stack-allocated memory."
+select r, "May return stack-allocated memory from $@.", va, va.toString()
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Memory Management/ReturnStackAllocatedMemory/ReturnStackAllocatedMemory.expected b/cpp/ql/test/query-tests/Likely Bugs/Memory Management/ReturnStackAllocatedMemory/ReturnStackAllocatedMemory.expected
@@ -1,7 +1,7 @@
-| test.cpp:17:2:17:12 | return ... | May return stack-allocated memory. |
-| test.cpp:25:2:25:12 | return ... | May return stack-allocated memory. |
-| test.cpp:47:2:47:11 | return ... | May return stack-allocated memory. |
-| test.cpp:54:2:54:16 | return ... | May return stack-allocated memory. |
-| test.cpp:92:2:92:12 | return ... | May return stack-allocated memory. |
-| test.cpp:112:2:112:12 | return ... | May return stack-allocated memory. |
-| test.cpp:119:2:119:19 | return ... | May return stack-allocated memory. |
+| test.cpp:17:2:17:12 | return ... | May return stack-allocated memory from $@. | test.cpp:17:10:17:11 | mc | mc |
+| test.cpp:25:2:25:12 | return ... | May return stack-allocated memory from $@. | test.cpp:23:18:23:19 | mc | mc |
+| test.cpp:47:2:47:11 | return ... | May return stack-allocated memory from $@. | test.cpp:47:9:47:10 | mc | mc |
+| test.cpp:54:2:54:16 | return ... | May return stack-allocated memory from $@. | test.cpp:54:11:54:12 | mc | mc |
+| test.cpp:92:2:92:12 | return ... | May return stack-allocated memory from $@. | test.cpp:89:10:89:11 | mc | mc |
+| test.cpp:112:2:112:12 | return ... | May return stack-allocated memory from $@. | test.cpp:112:9:112:11 | arr | arr |
+| test.cpp:119:2:119:19 | return ... | May return stack-allocated memory from $@. | test.cpp:119:11:119:13 | arr | arr |

Original file line number	Diff line number	Diff line change
`@@ -46,4 +46,4 @@ where`
`46`	`46`	`)`
`47`	`47`	`)`
`48`	`48`	`)`
`49`		`-select r, "May return stack-allocated memory."`
	`49`	`+select r, "May return stack-allocated memory from $@.", va, va.toString()`