JS: Add API-node version of getOwnOptions

asgerf · asgerf · commit b9d1b5584e07 · 2021-08-31T11:18:58.000+02:00
diff --git a/javascript/ql/lib/semmle/javascript/frameworks/Vue.qll b/javascript/ql/lib/semmle/javascript/frameworks/Vue.qll
@@ -139,6 +139,12 @@ module Vue {
       endcolumn = 0
     }
 
+    /**
+     * Gets an API node referring to the options passed to the Vue object,
+     * such as the object literal `{...}` in `new Vue{{...})` or the default export of a single-file component.
+     */
+    API::Node getOwnOptions() { none() } // overridden in subclass
+
     /**
      * Gets the options passed to the Vue object, such as the object literal `{...}` in `new Vue{{...})`
      * or the default export of a single-file component.
@@ -356,7 +362,7 @@ module Vue {
    * A Vue component from `new Vue({...})`.
    */
   class VueInstance extends Component, MkVueInstance {
-    DataFlow::NewNode def;
+    API::NewNode def;
 
     VueInstance() { this = MkVueInstance(def) }
 
@@ -368,6 +374,8 @@ module Vue {
       def.hasLocationInfo(filepath, startline, startcolumn, endline, endcolumn)
     }
 
+    override API::Node getOwnOptions() { result = def.getParameter(0) }
+
     override DataFlow::Node getOwnOptionsObject() { result = def.getArgument(0) }
 
     override Template::Element getTemplateElement() { none() }
@@ -389,6 +397,8 @@ module Vue {
       extend.hasLocationInfo(filepath, startline, startcolumn, endline, endcolumn)
     }
 
+    override API::Node getOwnOptions() { result = extend.getParameter(0) }
+
     override DataFlow::Node getOwnOptionsObject() { result = extend.getArgument(0) }
 
     override Template::Element getTemplateElement() { none() }
@@ -399,7 +409,7 @@ module Vue {
    */
   class ExtendedInstance extends Component, MkExtendedInstance {
     VueExtend extend;
-    DataFlow::NewNode sub;
+    API::NewNode sub;
 
     ExtendedInstance() { this = MkExtendedInstance(extend, sub) }
 
@@ -411,6 +421,8 @@ module Vue {
       sub.hasLocationInfo(filepath, startline, startcolumn, endline, endcolumn)
     }
 
+    override API::Node getOwnOptions() { result = sub.getParameter(0) }
+
     override DataFlow::Node getOwnOptionsObject() { result = sub.getArgument(0) }
 
     override DataFlow::Node getOption(string name) {
@@ -426,7 +438,7 @@ module Vue {
    * A Vue component from `Vue.component("my-component", { ... })`.
    */
   class ComponentRegistration extends Component, MkComponentRegistration {
-    DataFlow::CallNode def;
+    API::CallNode def;
 
     ComponentRegistration() { this = MkComponentRegistration(def) }
 
@@ -438,6 +450,8 @@ module Vue {
       def.hasLocationInfo(filepath, startline, startcolumn, endline, endcolumn)
     }
 
+    override API::Node getOwnOptions() { result = def.getParameter(1) }
+
     override DataFlow::Node getOwnOptionsObject() { result = def.getArgument(1) }
 
     override Template::Element getTemplateElement() { none() }
@@ -476,6 +490,13 @@ module Vue {
       )
     }
 
+    override API::Node getOwnOptions() {
+      exists(ExportDefaultDeclaration decl |
+        decl.getTopLevel() = getModule() and
+        result.getARhs() = DataFlow::valueNode(decl.getOperand())
+      )
+    }
+
     override DataFlow::Node getOwnOptionsObject() {
       exists(ExportDefaultDeclaration decl |
         decl.getTopLevel() = getModule() and
