Apply suggestions from code review

JLLeitschuh · smowton · web-flow · commit bafcce17d430 · 2022-02-09T22:14:17.000-05:00
Co-authored-by: Chris Smowton &lt;smowton@github.com&gt;
diff --git a/java/ql/src/Security/CWE/CWE-200/TempDirLocalInformationDisclosure.ql b/java/ql/src/Security/CWE/CWE-200/TempDirLocalInformationDisclosure.ql
@@ -121,7 +121,7 @@ private class TempDirSystemGetPropertyToCreateConfig extends TaintTracking::Conf
 
   override predicate isSink(DataFlow::Node sink) {
     sink instanceof FileCreationSink and
-    exists(TempDirSystemGetPropertyDirectlyToMkdirConfig config | not config.hasFlowTo(sink))
+    not any(TempDirSystemGetPropertyDirectlyToMkdirConfig config).hasFlowTo(sink)
   }
 
   override predicate isSanitizer(DataFlow::Node sanitizer) {
diff --git a/java/ql/src/Security/CWE/CWE-200/TempDirUtils.qll b/java/ql/src/Security/CWE/CWE-200/TempDirUtils.qll
@@ -44,7 +44,7 @@ class MethodFileCreateTempFile extends Method {
 }
 
 /**
- * Holds if `expDest` is some constructor call `new java.io.File(x)` and `expSource` is `x`.
+ * Holds if `expDest` is some constructor call `new java.io.File(expSource)`, where the specific `File` constructor being used has `paramCount` parameters.
  */
 predicate isFileConstructorArgument(Expr expSource, Expr exprDest, int paramCount) {
   exists(ConstructorCall construtorCall |

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ private class TempDirSystemGetPropertyToCreateConfig extends TaintTracking::Conf`
`121`	`121`
`122`	`122`	`override predicate isSink(DataFlow::Node sink) {`
`123`	`123`	`sink instanceof FileCreationSink and`
`124`		`- exists(TempDirSystemGetPropertyDirectlyToMkdirConfig config \| not config.hasFlowTo(sink))`
	`124`	`+ not any(TempDirSystemGetPropertyDirectlyToMkdirConfig config).hasFlowTo(sink)`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`override predicate isSanitizer(DataFlow::Node sanitizer) {`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ class MethodFileCreateTempFile extends Method {`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`/**`
`47`		- * Holds if `expDest` is some constructor call `new java.io.File(x)` and `expSource` is `x`.
	`47`	+ * Holds if `expDest` is some constructor call `new java.io.File(expSource)`, where the specific `File` constructor being used has `paramCount` parameters.
`48`	`48`	`*/`
`49`	`49`	`predicate isFileConstructorArgument(Expr expSource, Expr exprDest, int paramCount) {`
`50`	`50`	`exists(ConstructorCall construtorCall \|`