Boxed variable query: account for implicit-init variables

smowton · smowton · commit bb6e04456af3 · 2023-11-30T11:24:01.000Z
diff --git a/java/ql/src/Violations of Best Practice/Boxed Types/BoxedVariable.ql b/java/ql/src/Violations of Best Practice/Boxed Types/BoxedVariable.ql
@@ -63,7 +63,7 @@ from LocalBoxedVar v
 where
   forall(Expr e | e = v.getAnAssignedValue() | e.getType() = v.getPrimitiveType()) and
   (
-    not v.getDeclExpr().getParent() instanceof EnhancedForStmt or
+    not v.getDeclExpr().hasImplicitInit() or
     v.getDeclExpr().getParent().(EnhancedForStmt).getExpr().getType().(Array).getComponentType() =
       v.getPrimitiveType()
   ) and

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ from LocalBoxedVar v`
`63`	`63`	`where`
`64`	`64`	`forall(Expr e \| e = v.getAnAssignedValue() \| e.getType() = v.getPrimitiveType()) and`
`65`	`65`	`(`
`66`		`- not v.getDeclExpr().getParent() instanceof EnhancedForStmt or`
	`66`	`+ not v.getDeclExpr().hasImplicitInit() or`
`67`	`67`	`v.getDeclExpr().getParent().(EnhancedForStmt).getExpr().getType().(Array).getComponentType() =`
`68`	`68`	`v.getPrimitiveType()`
`69`	`69`	`) and`