Remove old arguments-array position

asgerf · asgerf · commit bbb1c8c374c1 · 2024-08-27T11:35:16.000+02:00
diff --git a/javascript/ql/lib/semmle/javascript/dataflow/internal/DataFlowPrivate.qll b/javascript/ql/lib/semmle/javascript/dataflow/internal/DataFlowPrivate.qll
@@ -790,7 +790,6 @@ newtype TParameterPosition =
   MkPositionalLowerBound(int n) { n = [0 .. getMaxArity()] } or
   MkThisParameter() or
   MkFunctionSelfReferenceParameter() or
-  MkArgumentsArrayParameter() or // TODO: remove
   MkStaticArgumentArray() or
   MkDynamicArgumentArray()
 
@@ -809,8 +808,6 @@ class ParameterPosition extends TParameterPosition {
 
   predicate isFunctionSelfReference() { this = MkFunctionSelfReferenceParameter() }
 
-  predicate isArgumentsArray() { this = MkArgumentsArrayParameter() } // TODO: remove
-
   predicate isStaticArgumentArray() { this = MkStaticArgumentArray() }
 
   predicate isDynamicArgumentArray() { this = MkDynamicArgumentArray() }
@@ -824,8 +821,6 @@ class ParameterPosition extends TParameterPosition {
     or
     this.isFunctionSelfReference() and result = "function"
     or
-    this = MkArgumentsArrayParameter() and result = "deprecated-arguments-array"
-    or
     this.isStaticArgumentArray() and result = "static-argument-array"
     or
     this.isDynamicArgumentArray() and result = "dynamic-argument-array"
diff --git a/javascript/ql/lib/semmle/javascript/dataflow/internal/FlowSummaryPrivate.qll b/javascript/ql/lib/semmle/javascript/dataflow/internal/FlowSummaryPrivate.qll
@@ -35,7 +35,7 @@ private predicate positionName(ParameterPosition pos, string operand) {
   or
   pos.isFunctionSelfReference() and operand = "function"
   or
-  pos.isArgumentsArray() and operand = "arguments-array"
+  pos.isDynamicArgumentArray() and operand = "arguments-array" // TODO: remove and handle automatically
   or
   operand = pos.asPositionalLowerBound() + ".."
 }

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ private predicate positionName(ParameterPosition pos, string operand) {`
`35`	`35`	`or`
`36`	`36`	`pos.isFunctionSelfReference() and operand = "function"`
`37`	`37`	`or`
`38`		`- pos.isArgumentsArray() and operand = "arguments-array"`
	`38`	`+ pos.isDynamicArgumentArray() and operand = "arguments-array" // TODO: remove and handle automatically`
`39`	`39`	`or`
`40`	`40`	`operand = pos.asPositionalLowerBound() + ".."`
`41`	`41`	`}`