C++: Remove an unecessary unresolveElement.

Max Schaefer · Max Schaefer · commit bccdf5963109 · 2019-12-17T10:15:43.000Z
As far as I can see, `@file` is not a `@usertype`, so this shouldn't be needed.
diff --git a/cpp/ql/src/semmle/code/cpp/XML.qll b/cpp/ql/src/semmle/code/cpp/XML.qll
@@ -20,7 +20,7 @@ abstract class XMLLocatable extends @xmllocatable {
     string filepath, int startline, int startcolumn, int endline, int endcolumn
   ) {
     exists(File f, Location l | l = this.getLocation() |
-      locations_default(l, unresolveElement(f), startline, startcolumn, endline, endcolumn) and
+      locations_default(l, f, startline, startcolumn, endline, endcolumn) and
       filepath = f.getAbsolutePath()
     )
   }

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ abstract class XMLLocatable extends @xmllocatable {`
`20`	`20`	`string filepath, int startline, int startcolumn, int endline, int endcolumn`
`21`	`21`	`) {`
`22`	`22`	`exists(File f, Location l \| l = this.getLocation() \|`
`23`		`- locations_default(l, unresolveElement(f), startline, startcolumn, endline, endcolumn) and`
	`23`	`+ locations_default(l, f, startline, startcolumn, endline, endcolumn) and`
`24`	`24`	`filepath = f.getAbsolutePath()`
`25`	`25`	`)`
`26`	`26`	`}`