C++: Add sanity test for missing operand type

dave-bartolomeo · dave-bartolomeo · commit bd46c430673e · 2019-02-11T09:47:00.000-08:00
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll
@@ -7,6 +7,7 @@ import cpp
 import semmle.code.cpp.ir.implementation.EdgeKind
 import semmle.code.cpp.ir.implementation.MemoryAccessKind
 import semmle.code.cpp.ir.implementation.Opcode
+private import semmle.code.cpp.Print
 private import semmle.code.cpp.ir.implementation.Opcode
 private import semmle.code.cpp.ir.internal.OperandTag
 
@@ -92,6 +93,14 @@ module InstructionSanity {
     )
   }
 
+  query predicate missingOperandType(Operand operand, string message) {
+    exists(Function func |
+      not exists(operand.getType()) and
+      func = operand.getUseInstruction().getEnclosingFunction() and
+      message = "Operand missing type in function '" + getIdentityString(func) + "'."
+    )
+  }
+
   /**
    * Holds if an instruction, other than `ExitFunction`, has no successors.
    */
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Instruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/raw/Instruction.qll
@@ -7,6 +7,7 @@ import cpp
 import semmle.code.cpp.ir.implementation.EdgeKind
 import semmle.code.cpp.ir.implementation.MemoryAccessKind
 import semmle.code.cpp.ir.implementation.Opcode
+private import semmle.code.cpp.Print
 private import semmle.code.cpp.ir.implementation.Opcode
 private import semmle.code.cpp.ir.internal.OperandTag
 
@@ -92,6 +93,14 @@ module InstructionSanity {
     )
   }
 
+  query predicate missingOperandType(Operand operand, string message) {
+    exists(Function func |
+      not exists(operand.getType()) and
+      func = operand.getUseInstruction().getEnclosingFunction() and
+      message = "Operand missing type in function '" + getIdentityString(func) + "'."
+    )
+  }
+
   /**
    * Holds if an instruction, other than `ExitFunction`, has no successors.
    */
diff --git a/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll b/cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll
@@ -7,6 +7,7 @@ import cpp
 import semmle.code.cpp.ir.implementation.EdgeKind
 import semmle.code.cpp.ir.implementation.MemoryAccessKind
 import semmle.code.cpp.ir.implementation.Opcode
+private import semmle.code.cpp.Print
 private import semmle.code.cpp.ir.implementation.Opcode
 private import semmle.code.cpp.ir.internal.OperandTag
 
@@ -92,6 +93,14 @@ module InstructionSanity {
     )
   }
 
+  query predicate missingOperandType(Operand operand, string message) {
+    exists(Function func |
+      not exists(operand.getType()) and
+      func = operand.getUseInstruction().getEnclosingFunction() and
+      message = "Operand missing type in function '" + getIdentityString(func) + "'."
+    )
+  }
+
   /**
    * Holds if an instruction, other than `ExitFunction`, has no successors.
    */
diff --git a/cpp/ql/test/library-tests/ir/ir/aliased_ssa_sanity.expected b/cpp/ql/test/library-tests/ir/ir/aliased_ssa_sanity.expected
@@ -2,6 +2,7 @@ missingOperand
 unexpectedOperand
 duplicateOperand
 missingPhiOperand
+missingOperandType
 instructionWithoutSuccessor
 ambiguousSuccessors
 unexplainedLoop
diff --git a/cpp/ql/test/library-tests/ir/ir/raw_sanity.expected b/cpp/ql/test/library-tests/ir/ir/raw_sanity.expected
@@ -2,6 +2,7 @@ missingOperand
 unexpectedOperand
 duplicateOperand
 missingPhiOperand
+missingOperandType
 instructionWithoutSuccessor
 ambiguousSuccessors
 unexplainedLoop
diff --git a/cpp/ql/test/library-tests/ir/ir/unaliased_ssa_sanity.expected b/cpp/ql/test/library-tests/ir/ir/unaliased_ssa_sanity.expected
@@ -2,6 +2,7 @@ missingOperand
 unexpectedOperand
 duplicateOperand
 missingPhiOperand
+missingOperandType
 instructionWithoutSuccessor
 ambiguousSuccessors
 unexplainedLoop
diff --git a/cpp/ql/test/library-tests/ir/ssa/aliased_ssa_sanity.expected b/cpp/ql/test/library-tests/ir/ssa/aliased_ssa_sanity.expected
@@ -2,6 +2,7 @@ missingOperand
 unexpectedOperand
 duplicateOperand
 missingPhiOperand
+missingOperandType
 instructionWithoutSuccessor
 ambiguousSuccessors
 unexplainedLoop
diff --git a/cpp/ql/test/library-tests/ir/ssa/unaliased_ssa_sanity.expected b/cpp/ql/test/library-tests/ir/ssa/unaliased_ssa_sanity.expected
@@ -2,6 +2,7 @@ missingOperand
 unexpectedOperand
 duplicateOperand
 missingPhiOperand
+missingOperandType
 instructionWithoutSuccessor
 ambiguousSuccessors
 unexplainedLoop
