Update cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll

MathiasVP · jketema · web-flow · commit bda46b3748fa · 2023-02-14T09:49:32.000Z
Co-authored-by: Jeroen Ketema &lt;93738568+jketema@users.noreply.github.com&gt;
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll
@@ -602,8 +602,8 @@ class InitialGlobalValue extends Node, TInitialGlobalValue {
     exists(DataFlowType type |
       type = globalDef.getUnspecifiedType() and
       if this.isGLValue()
-      then result = globalDef.getUnspecifiedType()
-      else result = getTypeImpl(type.getUnspecifiedType(), globalDef.getIndirectionIndex() - 1)
+      then result = type
+      else result = getTypeImpl(type, globalDef.getIndirectionIndex() - 1)
     )
   }
 

Original file line number	Diff line number	Diff line change
`@@ -602,8 +602,8 @@ class InitialGlobalValue extends Node, TInitialGlobalValue {`
`602`	`602`	`exists(DataFlowType type \|`
`603`	`603`	`type = globalDef.getUnspecifiedType() and`
`604`	`604`	`if this.isGLValue()`
`605`		`- then result = globalDef.getUnspecifiedType()`
`606`		`- else result = getTypeImpl(type.getUnspecifiedType(), globalDef.getIndirectionIndex() - 1)`
	`605`	`+ then result = type`
	`606`	`+ else result = getTypeImpl(type, globalDef.getIndirectionIndex() - 1)`
`607`	`607`	`)`
`608`	`608`	`}`
`609`	`609`