C++: Fix false positive

MathiasVP · MathiasVP · commit bdd058922397 · 2020-01-07T13:16:47.000+01:00
diff --git a/cpp/ql/src/Likely Bugs/Likely Typos/AssignWhereCompareMeant.ql b/cpp/ql/src/Likely Bugs/Likely Typos/AssignWhereCompareMeant.ql
@@ -81,5 +81,6 @@ predicate candidateVariable(Variable v) {
 from BooleanControllingAssignment ae, UndefReachability undef
 where
   candidateResult(ae) and
+  not ae.isFromUninstantiatedTemplate(_) and
   not undef.reaches(_, ae.getLValue().(VariableAccess).getTarget(), ae.getLValue())
 select ae, "Use of '=' where '==' may have been intended."
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Likely Typos/AssignWhereCompareMeant/AssignWhereCompareMeant.expected b/cpp/ql/test/query-tests/Likely Bugs/Likely Typos/AssignWhereCompareMeant/AssignWhereCompareMeant.expected
@@ -13,6 +13,4 @@
 | test.cpp:82:7:82:11 | ... = ... | Use of '=' where '==' may have been intended. |
 | test.cpp:84:7:84:11 | ... = ... | Use of '=' where '==' may have been intended. |
 | test.cpp:92:17:92:22 | ... = ... | Use of '=' where '==' may have been intended. |
-| test.cpp:105:6:105:10 | ... = ... | Use of '=' where '==' may have been intended. |
-| test.cpp:113:6:113:10 | ... = ... | Use of '=' where '==' may have been intended. |
 | test.cpp:113:6:113:10 | ... = ... | Use of '=' where '==' may have been intended. |
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Likely Typos/AssignWhereCompareMeant/test.cpp b/cpp/ql/test/query-tests/Likely Bugs/Likely Typos/AssignWhereCompareMeant/test.cpp
@@ -102,7 +102,7 @@ void g(int *i_p, int cond) {
 template<typename>
 void h() {
   int x;
-  if(x = 0) { // GOOD [FALSE POSITIVE]: x is not initialized so this is probably intensional
+  if(x = 0) { // GOOD: x is not initialized so this is probably intensional
   }
 
   int y = 0;

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ void g(int *i_p, int cond) {`
`102`	`102`	`template<typename>`
`103`	`103`	`void h() {`
`104`	`104`	`int x;`
`105`		`- if(x = 0) { // GOOD [FALSE POSITIVE]: x is not initialized so this is probably intensional`
	`105`	`+ if(x = 0) { // GOOD: x is not initialized so this is probably intensional`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`int y = 0;`