JS: Removed exclusion of FunctionExpr from compound statements.

Napalys · Napalys · commit bf48b5987478 · 2025-06-03T15:12:26.000+02:00
diff --git a/javascript/ql/lib/Expressions/ExprHasNoEffect.qll b/javascript/ql/lib/Expressions/ExprHasNoEffect.qll
@@ -139,8 +139,7 @@ predicate isCompoundExpression(Expr e) {
   or
   e instanceof SeqExpr
   or
-  e instanceof ParExpr and
-  not e.stripParens() instanceof FunctionExpr
+  e instanceof ParExpr
 }
 
 /**
diff --git a/javascript/ql/test/query-tests/Expressions/ExprHasNoEffect/ExprHasNoEffect.expected b/javascript/ql/test/query-tests/Expressions/ExprHasNoEffect/ExprHasNoEffect.expected
@@ -12,4 +12,3 @@
 | tst.js:50:3:50:36 | new Err ... age(e)) | This expression has no effect. |
 | tst.js:61:2:61:20 | o.trivialNonGetter1 | This expression has no effect. |
 | tst.js:77:24:77:24 | o | This expression has no effect. |
-| uselessfn.js:1:1:1:26 | (functi ... .");\\n}) | This expression has no effect. |
diff --git a/javascript/ql/test/query-tests/Expressions/ExprHasNoEffect/uselessfn.js b/javascript/ql/test/query-tests/Expressions/ExprHasNoEffect/uselessfn.js
@@ -1,3 +1,3 @@
-(function f() { // $ Alert
+(function f() { // $MISSING: Alert
   console.log("I'm never called.");
-})
+})

Original file line number	Diff line number	Diff line change
`@@ -139,8 +139,7 @@ predicate isCompoundExpression(Expr e) {`
`139`	`139`	`or`
`140`	`140`	`e instanceof SeqExpr`
`141`	`141`	`or`
`142`		`- e instanceof ParExpr and`
`143`		`- not e.stripParens() instanceof FunctionExpr`
	`142`	`+ e instanceof ParExpr`
`144`	`143`	`}`
`145`	`144`
`146`	`145`	`/**`