C++: remove comments about Java implies predicates

Robert Marsh · Robert Marsh · commit bf946c3ec3bc · 2018-11-06T12:02:38.000-08:00
The Java guards library includes a set of "implies" predicates to handle
short-circuiting conditionals. C++ handles those in IR generation, so
dominance on the IR produces correct results for controlling blocks.
diff --git a/cpp/ql/src/semmle/code/cpp/rangeanalysis/SignAnalysis.qll b/cpp/ql/src/semmle/code/cpp/rangeanalysis/SignAnalysis.qll
@@ -214,10 +214,6 @@ private predicate lowerBound(IRGuardCondition comp, Instruction lowerbound, Inst
     valueNumber(bounded) = valueNumber(compared) and
     bounded = pos.getAnOperand() and
     not unknownSign(lowerbound) and
-  /*
-   *  Java library uses guardControlsSsaRead here. I think that the phi node logic doesn't need to
-   * be duplicated but the implication predicates may need to be ported
-   */
    (
      isStrict = true and
      adjustment = 0
@@ -239,11 +235,6 @@ private predicate upperBound(IRGuardCondition comp, Instruction upperbound, Inst
     valueNumber(bounded) = valueNumber(compared) and
     bounded = pos.getAnOperand() and
     not unknownSign(upperbound) and
-    
-  /*
-   * Java library uses guardControlsSsaRead here. I think that the phi node logic doesn't need to
-   * be duplicated but the implication predicates may need to be ported
-   */
    (
      isStrict = true and
      adjustment = 0
