QLDocs

atorralba · atorralba · commit c138ed3e4da9 · 2021-05-05T16:51:15.000+02:00
diff --git a/java/ql/src/Security/CWE/CWE-749/UnsafeAndroidAccess.ql b/java/ql/src/Security/CWE/CWE-749/UnsafeAndroidAccess.ql
@@ -17,7 +17,7 @@ import semmle.code.java.security.UnsafeAndroidAccess
 import DataFlow::PathGraph
 
 /**
- * Taint configuration tracking flow from untrusted inputs to `loadUrl` or `postUrl` calls.
+ * Taint configuration tracking flow from untrusted inputs to a resource fetching call.
  */
 class FetchUntrustedResourceConfiguration extends TaintTracking::Configuration {
   FetchUntrustedResourceConfiguration() { this = "FetchUntrustedResourceConfiguration" }
diff --git a/java/ql/src/semmle/code/java/security/UnsafeAndroidAccess.qll b/java/ql/src/semmle/code/java/security/UnsafeAndroidAccess.qll
@@ -1,4 +1,5 @@
 /**
+ * Provides classes to reason about Unsafe Resource Fetching vulnerabilities in Android.
  */
 
 import java
@@ -7,6 +8,9 @@ import semmle.code.java.dataflow.DataFlow
 import semmle.code.java.dataflow.ExternalFlow
 
 /**
+ * A sink that represents a method that fetches a web resource.
+ *
+ * Extend this class to add your own Unsafe Resource Fetching sinks.
  */
 abstract class UrlResourceSink extends DataFlow::Node {
   /**
@@ -15,9 +19,7 @@ abstract class UrlResourceSink extends DataFlow::Node {
   abstract string getSinkType();
 }
 
-/**
- * A URL argument to a `loadUrl` or `postUrl` call, considered as a sink.
- */
+/** CSV sink models representing methods susceptible to Unsafe Resource Fetching attacks. */
 private class DefaultUrlResourceSinkModel extends SinkModelCsv {
   override predicate row(string row) {
     row =
