Merge pull request #1810 from markshannon/python-speedup-slow-predicate

taus-semmle · web-flow · commit c6c307ffefeb · 2019-08-24T11:35:09.000+02:00
Python: Prevent bad magic in one predicate.
diff --git a/python/ql/src/semmle/python/objects/Constants.qll b/python/ql/src/semmle/python/objects/Constants.qll
@@ -78,6 +78,7 @@ abstract class ConstantObjectInternal extends ObjectInternal {
 
 }
 
+pragma[nomagic]
 private boolean callToBool(CallNode call, PointsToContext context) {
     PointsToInternal::pointsTo(call.getFunction(), context, ClassValue::bool(), _) and
     exists(ObjectInternal arg |

Original file line number	Diff line number	Diff line change
`@@ -78,6 +78,7 @@ abstract class ConstantObjectInternal extends ObjectInternal {`
`78`	`78`
`79`	`79`	`}`
`80`	`80`
	`81`	`+pragma[nomagic]`
`81`	`82`	`private boolean callToBool(CallNode call, PointsToContext context) {`
`82`	`83`	`PointsToInternal::pointsTo(call.getFunction(), context, ClassValue::bool(), _) and`
`83`	`84`	`exists(ObjectInternal arg \|`