JS: Add UselessConditional test

asgerf · asgerf · commit c86981256339 · 2020-05-18T22:29:32.000+01:00
diff --git a/javascript/ql/test/query-tests/Statements/UselessConditional/UselessConditional.expected b/javascript/ql/test/query-tests/Statements/UselessConditional/UselessConditional.expected
@@ -29,6 +29,7 @@
 | UselessConditional.js:151:6:151:6 | v | This use of variable 'v' always evaluates to true. |
 | UselessConditional.js:163:5:163:17 | findOrThrow() | This call to findOrThrow always evaluates to true. |
 | UselessConditional.js:166:6:166:6 | v | This use of variable 'v' always evaluates to true. |
+| UselessConditional.js:183:17:183:18 | !x | This negation always evaluates to true. |
 | UselessConditionalGood.js:58:12:58:13 | x2 | This use of variable 'x2' always evaluates to false. |
 | UselessConditionalGood.js:69:12:69:13 | xy | This use of variable 'xy' always evaluates to false. |
 | UselessConditionalGood.js:85:12:85:13 | xy | This use of variable 'xy' always evaluates to false. |
diff --git a/javascript/ql/test/query-tests/Statements/UselessConditional/UselessConditional.js b/javascript/ql/test/query-tests/Statements/UselessConditional/UselessConditional.js
@@ -176,3 +176,17 @@ async function awaitFlow(){
 	if (v) { // OK
 	}
 });
+
+(function() {
+    function outer(x) {
+        addEventListener("click", () => {
+            if (!x && something()) { // NOT OK
+                something();
+            }
+        });
+    }
+    function inner() {
+        outer(); // Omit parameter
+    }
+    inner();
+});
