C++: Update use of deprecated methods.

geoffw0 · geoffw0 · commit c9ec30fa2aac · 2020-04-02T19:49:42.000+01:00
diff --git a/cpp/ql/src/semmle/code/cpp/models/implementations/Strings.qll b/cpp/ql/src/semmle/code/cpp/models/implementations/Strings.qll
@@ -8,8 +8,8 @@ class StringConstructor extends TaintFunction {
 
   override predicate hasTaintFlow(FunctionInput input, FunctionOutput output) {
     // flow from any constructor argument to return value
-    input.isInParameter(_) and
-    output.isOutReturnValue()
+    input.isParameter(_) and
+    output.isReturnValue()
   }
 }
 
@@ -21,7 +21,7 @@ class StringCStr extends TaintFunction {
 
   override predicate hasTaintFlow(FunctionInput input, FunctionOutput output) {
     // flow from string itself (qualifier) to return value
-    input.isInQualifier() and
-    output.isOutReturnValue()
+    input.isQualifierObject() and
+    output.isReturnValue()
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -8,8 +8,8 @@ class StringConstructor extends TaintFunction {`
`8`	`8`
`9`	`9`	`override predicate hasTaintFlow(FunctionInput input, FunctionOutput output) {`
`10`	`10`	`// flow from any constructor argument to return value`
`11`		`- input.isInParameter(_) and`
`12`		`- output.isOutReturnValue()`
	`11`	`+ input.isParameter(_) and`
	`12`	`+ output.isReturnValue()`
`13`	`13`	`}`
`14`	`14`	`}`
`15`	`15`
`@@ -21,7 +21,7 @@ class StringCStr extends TaintFunction {`
`21`	`21`
`22`	`22`	`override predicate hasTaintFlow(FunctionInput input, FunctionOutput output) {`
`23`	`23`	`// flow from string itself (qualifier) to return value`
`24`		`- input.isInQualifier() and`
`25`		`- output.isOutReturnValue()`
	`24`	`+ input.isQualifierObject() and`
	`25`	`+ output.isReturnValue()`
`26`	`26`	`}`
`27`	`27`	`}`