JS: Ensure correct value is used in parseNameExpression()

asgerf · asgerf · commit cc2bec08084b · 2025-03-27T11:51:21.000+01:00
The call to expect() below here updates 'token' and 'value' to that of the NEXT token (not the name).

The code happened to work because the 'value' field is only updated if a token with a relevant value is found. E.g. if a name token could be followed by another name, then we would have seen the wrong name here.
diff --git a/javascript/extractor/src/com/semmle/js/parser/JSDocParser.java b/javascript/extractor/src/com/semmle/js/parser/JSDocParser.java
@@ -829,6 +829,7 @@ private JSDocTypeExpression parseRecordType() throws ParseError {
 
     private JSDocTypeExpression parseNameExpression() throws ParseError {
       SourceLocation loc = loc();
+      Object value = this.value; // save the value of the current token
       expect(Token.NAME);
       // Hacky initial implementation with wrong locations
       String[] parts = value.toString().split("\\.");
