JavaScript: Abort AutoBuild if an exception happens in one of the extractor threads.

Max Schaefer · Max Schaefer · commit ce65fcedc121 · 2019-01-17T09:29:49.000Z
diff --git a/javascript/extractor/src/com/semmle/js/extractor/AutoBuild.java b/javascript/extractor/src/com/semmle/js/extractor/AutoBuild.java
@@ -671,8 +671,10 @@ private void doExtract(FileExtractor extractor, Path file, ExtractorState state)
 			long start = logBeginProcess("Extracting " + file);
 			extractor.extract(f, state);
 			logEndProcess(start, "Done extracting " + file);
-		} catch (IOException e) {
-			throw new ResourceError("Exception while extracting " + file + ".", e);
+		} catch (Throwable t) {
+			System.err.println("Exception while extracting " + file + ".");
+			t.printStackTrace(System.err);
+			System.exit(1);
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -671,8 +671,10 @@ private void doExtract(FileExtractor extractor, Path file, ExtractorState state)`
`671`	`671`	`long start = logBeginProcess("Extracting " + file);`
`672`	`672`	`extractor.extract(f, state);`
`673`	`673`	`logEndProcess(start, "Done extracting " + file);`
`674`		`- } catch (IOException e) {`
`675`		`- throw new ResourceError("Exception while extracting " + file + ".", e);`
	`674`	`+ } catch (Throwable t) {`
	`675`	`+ System.err.println("Exception while extracting " + file + ".");`
	`676`	`+ t.printStackTrace(System.err);`
	`677`	`+ System.exit(1);`
`676`	`678`	`}`
`677`	`679`	`}`
`678`	`680`