Add class for XML Attributes meant to hold an identifier in AndroidManifest

egregius313 · egregius313 · commit cf3e5a0abe5f · 2022-12-06T23:11:47.000-05:00
Some Android component attributes hold an identifier (e.g.
`android:name` and `android:targetActivity` for `&lt;activity-alias&gt;`).
diff --git a/java/ql/lib/semmle/code/xml/AndroidManifest.qll b/java/ql/lib/semmle/code/xml/AndroidManifest.qll
@@ -212,6 +212,13 @@ class AndroidPermissionXmlAttribute extends XmlAttribute {
   predicate isWrite() { this.getName() = "writePermission" }
 }
 
+/**
+ * The attribute `android:name` or `android:targetActivity`.
+ */
+class AndroidIdentifierXmlAttribute extends AndroidXmlAttribute {
+  AndroidIdentifierXmlAttribute() { this.getName() = ["name", "targetActivity"] }
+}
+
 /**
  * The `<path-permission`> element of a `<provider>` in an Android manifest file.
  */
