C++: Document Node0Impl, remove a debug change.

geoffw0 · geoffw0 · commit cfc1a3db222c · 2024-02-01T13:13:50.000Z
diff --git a/cpp/ql/lib/semmle/code/cpp/dataflow/internal/FlowSummaryImpl.qll b/cpp/ql/lib/semmle/code/cpp/dataflow/internal/FlowSummaryImpl.qll
@@ -89,7 +89,7 @@ module Input implements InputSig<DataFlowImplSpecific::CppDataFlow> {
   }
 }
 
-/*private*/ import Make<DataFlowImplSpecific::CppDataFlow, Input> as Impl
+private import Make<DataFlowImplSpecific::CppDataFlow, Input> as Impl
 
 private module StepsInput implements Impl::Private::StepsInputSig {
   DataFlowCall getACall(Public::SummarizedCallable sc) { result.getStaticCallTarget() = sc }
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll
@@ -94,6 +94,11 @@ module NodeStars {
 
 import NodeStars
 
+/**
+ * A cut-down `DataFlow::Node` class that does not depend on the output of SSA.
+ * This can thus be safely used in the SSA computations themselves, as well as
+ * in construction of other node classes (`TIRDataFlowNode`).
+ */
 class Node0Impl extends TIRDataFlowNode0 {
   /**
    * INTERNAL: Do not use.

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ module Input implements InputSig<DataFlowImplSpecific::CppDataFlow> {`
`89`	`89`	`}`
`90`	`90`	`}`
`91`	`91`
`92`		`-/private/ import Make<DataFlowImplSpecific::CppDataFlow, Input> as Impl`
	`92`	`+private import Make<DataFlowImplSpecific::CppDataFlow, Input> as Impl`
`93`	`93`
`94`	`94`	`private module StepsInput implements Impl::Private::StepsInputSig {`
`95`	`95`	`DataFlowCall getACall(Public::SummarizedCallable sc) { result.getStaticCallTarget() = sc }`