Merge pull request #6748 from bmuskalla/fixHiddenTypesTestGenerator

Benjamin Muskalla · web-flow · commit d09c3bf8638b · 2021-09-29T09:27:13.000+02:00
Java: Avoid stubbing methods with private parameter types
diff --git a/java/ql/src/utils/stub-generator/Stubs.qll b/java/ql/src/utils/stub-generator/Stubs.qll
@@ -361,6 +361,12 @@ private predicate excludedMember(Member m) {
   m.(Method).getDeclaringType() instanceof EnumType and
   m.hasName(["values", "valueOf"]) and
   m.isStatic()
+  or
+  exists(Parameter p |
+    p = m.(Method).getAParameter() and
+    p.getType().fromSource() and
+    not p.getType().(RefType).isPublic()
+  )
 }
 
 private string stubMember(Member m) {
